search

kraanzu / dooit

An awesome TUI todo manager
https://pypi.org/project/dooit/
MIT License
2.07k stars 100 forks source link

[BUG] Sort mode broken, when canceling with <ctrl+s> instead of <esc> #175

Open LanceTheDev opened 6 months ago

LanceTheDev commented 6 months ago

Describe the bug 🐛 When I cancel the sort mode with <ctrl+s> instead of key, it's not toggleable anymore afterwards. I need to restart the application to make it work again.

To Reproduce 🐣

  1. Open sort menu by pressing <ctrl+s>
  2. Cancel sort menu by pressing <ctrl+s> instead of
  3. Menu closes, but mode stays is "SORT"

Expected behavior 🤔 Mode should switch back to NORMAL and sort menu should be toggleable afterwards

Desktop (please complete the following information): 🤖

kraanzu commented 6 months ago

It's weird behavior indeed. Fortunately escape works. I'll look into this

LanceTheDev commented 6 months ago

I would like to take a look into that issue as well. I believe my python skills should at least be good enough to identify the root cause. If you agree, I will take a look into it the coming days and report back.

kraanzu commented 6 months ago

Sure thing. The code might be a bit messy (I'm planning on a re-work) so feel free to ping me for any pointers

LanceTheDev commented 6 months ago

I haven't had the time yet, to tackle this and wanted to reaffirm you of my willingness to do so. Next week, starting on wednesday, I will take a few days off of work and will make sure, to start with it :+1:

kraanzu commented 6 months ago

Thanks for the confirmation! Do give me a heads up if you start with anything :)

I will take a few days off of work and will make sure, to start with it 👍

Ay! Don't stress too much about it man. And days off are for relaxing :sunglasses: