search

kraemer-lab / GRAPEVNE

Graphical Analytical Pipeline Development Evironment
MIT License
6 stars 3 forks source link

[BUG]: Building MacOS-12 and -14 in parallel can stall code-signing #243

Open jsbrittain opened 3 months ago

jsbrittain commented 3 months ago

Describe the bug It is noticeable (especially on the nightly builds, e.g. https://github.com/kraemer-lab/GRAPEVNE/actions/runs/8811137693) that the (slower) macOS-12 build will stall at the code-signing stage. When re-run the build usually passes without issue. It seems highly likely that there is an issue submitting and receiving approval of both builds at the same time.

To Reproduce Check the regular nightly build logs.

Expected behavior Both macOS builds should pass first-time

Environment (please complete the following information): github

Additional context A suggested solution is to run the macOS builds in series (instead of their current parallel setup); since the aarch builds are much faster, it is recommended to run the macOS-14 build before the macOS-12 build.

jsbrittain commented 3 months ago

It is also recommended to put a backboard on the permitted execution time for the runner (2 hrs seems reasonable), to prevent the runners extending to their maximum allowance (of 6hrs) permitted by github.

jsbrittain commented 1 month ago

_Use jobs..needs to identify any jobs that must complete successfully before this job will run._ https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idneeds