krafit / wp-gitlab-updater

♻️ WordPress plugin to get updates for themes and plugins from private GitLab repos — can also be implemented into a plugin or theme.
58 stars 24 forks source link

Prevent crash with theme or plugin updates from W.org with the same slug #1

Closed florianbrinkmann closed 7 years ago

florianbrinkmann commented 7 years ago

Currently, the script does not consider conflicts with theme or plugin updates from the W.org repo, where the slug is identical with a theme or plugin which uses the script.

Should be possible to check for that inside the theme_update() and plugin_update() method. If this runs after the core adds available updates from W.org to the transient, we can check there if a W.org update is set for our theme/plugin, and unset it.

florianbrinkmann commented 7 years ago

First step done in 03ec053727170c001d7c1665eba5ef02b610a388 and 5e6cdf0c43771b3142ececf4bb4535adaca437f0 — works only if plugin and theme is active.