krafit / wp-gitlab-updater

♻️ WordPress plugin to get updates for themes and plugins from private GitLab repos — can also be implemented into a plugin or theme.
58 stars 24 forks source link

Gitlab updated not working with new Worpdpress ? #18

Open pvi-github opened 2 years ago

pvi-github commented 2 years ago

Hello,

With my Wordpress 5.9.3 wp-gitlab-updater started to raise errors on line 56 of them-updater.php and 103 of plugin-updater.php

I guess that get_site_option does not return an array any more for some reason...

Is there somebody active in here to answer this question ?

With my best regards, PVI

florianbrinkmann commented 2 years ago

Hi,

could you post the errors you get?

pvi-github commented 2 years ago

Hi,

Thansk for answering.

Here is the kind of message i get :

Warning: Trying to access array offset on value of type bool in /var/www/wp-content/plugins/wp-gitlab-updater/src/plugin-updater.php on line 103 Warning: Trying to access array offset on value of type bool in /var/www/wp-content/plugins/wp-gitlab-updater/src/plugin-updater.php on line 103 Warning: Trying to access array offset on value of type bool in /var/www/wp-content/plugins/wp-gitlab-updater/src/plugin-updater.php on line 103 Warning: Trying to access array offset on value of type bool in /var/www/wp-content/plugins/wp-gitlab-updater/src/plugin-updater.php on line 103 Warning: Trying to access array offset on value of type bool in /var/www/wp-content/plugins/wp-gitlab-updater/src/plugin-updater.php on line 103 Warning: Trying to access array offset on value of type bool in /var/www/wp-content/plugins/wp-gitlab-updater/src/plugin-updater.php on line 103 Warning: Trying to access array offset on value of type bool in /var/www/wp-content/plugins/wp-gitlab-updater/src/plugin-updater.php on line 103 Warning: Trying to access array offset on value of type bool in /var/www/wp-content/plugins/wp-gitlab-updater/src/plugin-updater.php on line 103 Warning: Trying to access array offset on value of type bool in /var/www/wp-content/plugins/wp-gitlab-updater/src/plugin-updater.php on line 103

These messages appear when i activate the plugin : at the top of the page and also later in the body of the admin page just above the table showing the list of plugins

It seems it is repeated as much as i have plugins... i dit not put all the messages but they are all the same.

I tried to patch the code to skip the rest of the loops when the $plugin is not an array : the error message disappears but the managed plugins do not get updates

So what i tried hides the problem but does not solve it...

Is that enough to analyse the issue ?

(edit : updated for a better look)

jonasfresewebdev commented 1 year ago

@florianbrinkmann is there any update on this? I got the same error.

florianbrinkmann commented 1 year ago

Hi @jonasfresewebdev, no, sorry. @pvi-github thanks for providing the error log and sorry for not getting back. I don’t use the package myself and don’t have the time to dive back into the project to debug issues, so the repo will be archived…

pvi-github commented 1 year ago

Hello,

Thanks for sharing this status information... ups and downs of projects... that's opensource life, but maybe someone can take over after you Florian ?

I've seen a fork with several commits ahead of yours by @lukasleitsch

There : https://github.com/lukasleitsch/wp-gitlab-updater

Maybe you can tell us more about what you did @lukasleitsch ?

Kind regards,

lukasleitsch commented 1 year ago

@pvi-github My fork adds basically composer support and I guess I changed a bit the structure for my needs.

pvi-github commented 1 year ago

Hi @lukasleitsch ,

Thanks for your answer... do you meet the array offset issue mentioned in this issue ?

If by chance you solved this, it could be of great help to @jonasfresewebdev and myself

After that maybe we can join forces to maintain it (and have it accepted in official Wordpress repos) ?

Kind regards,

lukasleitsch commented 1 year ago

Thanks for your answer... do you meet the array offset issue mentioned in this issue ?

Sorry, you issue mentioned above don't occur in my fork. But I only use the Theme Updater. In your case the plugin updater throws the error.

pvi-github commented 1 year ago

ay caràmba !

:-D

Ok i guess i will have to fix this myself then...