Sigil II with Thorr soundtrack crashes DSDA-Doom on exit

kraflab / dsda-doom

This is a successor of prboom+ with extra tooling for demo recording and playback, with a focus on speedrunning and quality of life.

338 stars 86 forks source link

Sigil II with Thorr soundtrack crashes DSDA-Doom on exit #465

Open mooreye opened 10 months ago

mooreye commented 10 months ago

Romero's Sigil II with Thorr's MP3 soundtrack crashes the game when I exit it:

mad_registersong succeed. bitrate 320000 samplerate 48000
The game has crashed!
Please report the following information: Segmentation fault (0x0000)

However it seems to crash only when you manually quit Dsda-doom, playing it works fine. Without the MP3 soundtrack no issue occurs.

spazzylemons commented 10 months ago

I'm able to reproduce this even with a single PWAD containing a single MP3. There seems to be a race condition where the MP3 music player is destroyed while still being used in the audio callback.

kraflab commented 3 months ago

Can't reproduce this. If this is a race condition it might just not happen on my hardware, in which case someone who can reproduce it would need to debug it and find the error.