kraftbj / genesis-enews-extended

WordPress widget to provide additional functionality to the Genesis eNews widget.
https://kraft.blog/genesis-enews-extended/
Other
12 stars 15 forks source link

Duplicate subbox and subbutton IDs when multiple eNews widgets used #144

Closed nickcernis closed 5 years ago

nickcernis commented 5 years ago

Duplicate form IDs were solved in #113.

But using multiple eNews widgets on a single page still results in duplicate IDs for subbutton and subbox:

<form id="subscribeenews-ext-2" action="#" method="post" …>
<label for="subbox" class="screenread">Your Email Address</label><input type="email" value="" id="subbox" placeholder="Your Email Address" name="#" required="required">
<input type="submit" value="Sign Up" id="subbutton">
</form>
kraftbj commented 5 years ago

That's a bit of a BC nightmare there.

In trying to preserve styling for some older themes that style on #subbutton, etc, we can't use different ones without breaking styling.

My goal is to create a eNews block that will deprecate the widget and won't suffer from that defect.