search

kraftbj / genesis-enews-extended

WordPress widget to provide additional functionality to the Genesis eNews widget.
https://kraft.blog/genesis-enews-extended/
Other
12 stars 15 forks source link

Fix incorrect esc_* (was: Name fields should clear onclick) #36

Closed kraftbj closed 11 years ago

kraftbj commented 11 years ago

On personal site, the fname field doesn't clear onclear requiring user to delete stock text him/herself.

kraftbj commented 11 years ago

Correction - Adding a single quote to the label field setting causes the issue (e.g. "What's your name" fails while "What is your name" works as intended.)

kraftbj commented 11 years ago

Discovered that I was using esc_attr instead of esc_js in the first and last name fields.