search

kraftbj / genesis-enews-extended

WordPress widget to provide additional functionality to the Genesis eNews widget.
https://kraft.blog/genesis-enews-extended/
Other
12 stars 15 forks source link

MailPoet integration #90

Closed maor closed 10 years ago

maor commented 10 years ago

Hey Brandon!

So MailPoet is now fully integrated. The fine folks from MailPoet and I have tested it, and it seems to be working just great. Let me know what you think! ( :

kraftbj commented 10 years ago

This is great. Let me give it a close look and a bit of testing.

kraftbj commented 10 years ago

Hey!

Thanks again for all of this work. A couple things/questions.

I'll make both changes, but wanted to run both past you in case I'm missing something.

maor commented 10 years ago

Hi Brandon!

Is there a use case where a MailPoet subscribe (e.g. clicking submit on the form) should open in a new window? I don't see one, so I'd like to force same window for MailPoet (like we force new window for Feedburner, since no one wants it otherwise ;-)

You are absolutely right, there is no use for that. I most probably missed this one.

I'm going to add the current page's URL in the form action attribute so the form remains valid HTML5.

Spot on. This is great!

Thanks for checking with me and for taking the time to review this pull request! If there's anything you'd like me to take care of please do let me know! : )