search

kraftcloud / go-sdk

KraftCloud Go SDK
https://pkg.go.dev/sdk.kraft.cloud
BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Logs() call is broken #6

Closed jake-ciolek closed 1 year ago

jake-ciolek commented 1 year ago

The instance example is broken and the Logs() call doesn't work anymore:

could not get instance logs: performing the request: error parsing response: json: Unmarshal(non-pointer kraftcloud.ServiceResponse[sdk.kraft.cloud/instance.Instance])

Ran into it while trying to adapt kraftkit to the refactored sdk.

antoineco commented 1 year ago

I wonder how the linter didn't catch that. Maybe it doesn't descend into submodules.

Edit: yes, that was it

antoineco commented 1 year ago

I tried locally with absolutely all linters enabled, and none of them detected the issue 🥲