search

kraftvaerk / generator-rammevaerk

Scaffold a web project in kraftvaerk style
MIT License
5 stars 4 forks source link

Dynamic import #19

Closed mi2oon closed 6 years ago

mi2oon commented 6 years ago

This introduces dynamic import along with a few hotfixes. But lets see if we can avoid bable-eslint in the future 😉

Close #15

kristoforsalmin commented 6 years ago

@mi2oon Looks great! Jest is a nice testing tool 😄

A quick question: Is there a reason for using entire @babel/preset-stage-3? Maybe we can just use @babel/syntax-dynamic-import which is more specific to our cause? Also there'll be no issues when they move import() to a next stage.

As for babel-eslint, yes, it seems like we should wait till import() hits the final stage 😞

mi2oon commented 6 years ago

@racse1 Jest just seemed a bit more comprehensive and stable I guess ;)

As for including the whole preset. Well, I mainly did that because I also like to use @babel/plugin-proposal-object-rest-spread and @babel/plugin-proposal-class-properties but perhaps we should be more specific. Your call 😀