search

kraftvaerk / generator-rammevaerk

Scaffold a web project in kraftvaerk style
MIT License
5 stars 4 forks source link

Use Browserslist #2

Closed kristoforsalmin closed 6 years ago

kristoforsalmin commented 6 years ago

Hi there,

I'm thinking, maybe it's a good idea to use Browserslist (via .browserslistrc) instead of config entry? Autoprefixer already supports it out of box. babel-preset-env also is also going to support it starting from next version, I believe.

Then we can potentially remove explicit configuration from here and here.

I can create a feature branch for now and we can merge it later once babel-preset-env gets released. How does it sound?

Thanks

mi2oon commented 6 years ago

🎉1st issue @racse1 👯

Great to see someone actually looking though and giving suggestions. For years it's basically only been me. It is important to have a on going to at this as this generator serves as a base of all of our new projects.

Nevertheless, it's a great idea to use Browserslist (via .browserslistrc) The config entry was just some old code waiting to be removed when bable preset env started supporting it.

But just go ahead and create that feature branch and lets wait for the next version of Bable.. it has a lot of other goodies regarding smarter transpiling too.. so can't wait :D

kristoforsalmin commented 6 years ago

@mi2oon Glad to help! I wish I would've done it earlier, though. Let's try to keep the ball rolling 😄