Scoped npm packages - Githubissues

kraftvaerk / generator-rammevaerk

Scaffold a web project in kraftvaerk style

MIT License

5 stars 4 forks source link

Scoped npm packages #38

Closed kristoforsalmin closed 5 years ago

kristoforsalmin commented 6 years ago

Hi everyone,

What do you think about moving all our packages under kraftvaerk scope?

[x] generator-rammevaerk => @kraftvaerk/generator-rammevaerk
[x] eslint-config-kraftvaerk => @kraftvaerk/eslint-config
[x] stylelint-config-kraftvaerk => @kraftvaerk/stylelint-config
[x] kv.cookieconsent => @kraftvaerk/cookieconsent

I'm a bit uncertain about shareable configs, because I think it makes sense to use same name for repo and npm package, so maybe we can just stick to what we currently have (e.g. @kraftvaerk/eslint-config-kraftvaerk).

mi2oon commented 5 years ago

@racse1 I would love that.. I'll have a look at the npm part. However, what about the repos on git? Should we then also move to a mono-repo structure?

kristoforsalmin commented 5 years ago

@mi2oon Well, that's completely up to us. I mean having a scope doesn't force us to go monorepo, does it? 😄 I doubt we actually need a monorepo — our packages can be perfectly used independently and we don't have to fiddle with Lerna or think about structuring issues and pull requests.

If you think it'd be better with monorepo — I'm happy to know why 👍 At the same time I think it's very convenient way of handling large number of, let's say, helpers or components.

kristoforsalmin commented 5 years ago

Description updated 👆

mi2oon commented 5 years ago

@racse1 Updated little more. I decided to keep things pretty much like today and switched to scoped on npm.