notice

[jontonsoup4]

Description

In order to thematically maintain the senpai narrative of json, I propose keeping in character by changing the implementation of imports to notice. Since the current preferred method is importing magic which essentially does the same thing as imports, changing this method to senpai will keep with the theme and allow jsonsenpai to notice me.

In addition, imp is a depreciated lib, so I changed that to types instead. The same functionality takes place. I also cleaned up some formatting because senpai likes his code neat.

Before

with jsonsempai.imports():
    import me

After

with jsonsempai.notice():
    import me

[AbstractBeliefs]

:+1: pls merge this thx

[Cediddi]

+1 I think this PR really improves the application.

[nbasu02]

Wouldn't it be better to have these names as aliases for the existing functions? We don't want to break existing code that relies on this library.

[jontonsoup4]

If you're currently doing the long handed imports instead of the one line magic, you don't deserve to be noticed by senpai

[Cediddi]

Or rather, you don't deserve to be noticed by senpai.

On Jan 25 2016, at 9:16 pm, Jonathan Reed <notifications@github.com> wrote:

If you're currently doing the long handed imports instead of the one line magic, senpai doesn't deserve to notice you

—
Reply to this email directly or view it on GitHub.

[AlexHLPham]

crucial update pls notice.

[zig-for]

Is it possible to allow

notice my_json_file

?

[milkey-mouse]

@nbasu02 You say that as if something would rely on this library.

[nbasu02]

@milkey-mouse that's the joke

[hyonschu]

this is the first github commit i slow clapped

[jontonsoup4]

I added back an alias for the legacy imports() meaning that previous dependencies on this module will not be broken. This PR now has thematic importance as well as backwards compatibility back to any applications running this on 2.6