search

krahabb / meross_lan

Home Assistant integration for Meross devices
MIT License
423 stars 47 forks source link

Fix Issue MTS960 API change #455

Closed bernardpe closed 3 months ago

bernardpe commented 3 months ago

Hi,

I was facing to somes issue using MTS960, is seems that interface has been changed since. I made the evolution to make the solution working.

Regards, Bernard

bernardpe commented 3 months ago

related to Issue on Managing MTS960 due to API change

449

krahabb commented 3 months ago

Hello @bernardpe, Thank you for the PR. I've just better checked the diff and everything looks ok. I'd just want to slightly refactor the _mts_working moving it to the inherited (MTS960) thermostat class instead of the base MTSClimate since it's really a custom feature not present in any other MTSClimate derived class. I'd fix that directly in your branch but I'm in a rush at the moment (and I guess I can't directly touch it without going with a fork-PR on your repo). If you can manage it I would be grateful else I guess I could just merge this and then apply the edit on my repo. I think I'll manage it over-night or so in order to promptly merge this.

bernardpe commented 3 months ago

Hi

No problem I will do the work for tomorrow !

Bernard

bernardpe commented 3 months ago

Hi, change has been made and I fix the issue of the test as well. Bernard