search

kraigs-android / kraigsandroid

Kraig's android applications
26 stars 26 forks source link

Use system alarm sound by default #145

Closed Zukero closed 3 years ago

Zukero commented 3 years ago

Instead of notification ringtone, use the system alarm ringtone by default. "Internal" media picker offer the three system-wide sound types : alarm, notification or ringtone.

See issue #144

kraigs-android commented 3 years ago

This looks good to me, thanks for putting it together. Would you mind also updating the use of DEFAULT_NOTIFICATION_URI in AlarmNotificationService.java and AlarmOptions.java as well? These are for playing a backup sound when the configured one can't be played. I imagine it makes sense to use the default alarm sound instead of the default notification sound in these cases as well.

Zukero commented 3 years ago

Sure, as soon as I get the chance.

Zukero commented 3 years ago

Just did it from the github web UI. Never compiled nor tested, but seems trivial enough.