search

krainboltgreene / termnote

Keynotes in your flippin' TERMINAL!
http://krainboltgreene.github.com/termnote
MIT License
273 stars 22 forks source link

Positioning fixes #5

Closed mileszs closed 11 years ago

mileszs commented 11 years ago

On OSX, using both Terminal and iTerm2, I was experiencing poor positioning; everything was off-center to my right, and code was left-aligned, and sometimes off screen to the top. The included commits work very well for me, but will need testing by others.

To be more specific, I think the gutter and space overrides in Pane::Code will work for everyone. I think the change I made to window width -- arbitrarily subtracting 50 -- is only optimal for my screen width. I am essentially punting on that one for the moment. I will be using these slides at tonight's Indianapolis Ruby Brigade meetup, and thus am in a sort of "hey works for now" situation. :-)

krainboltgreene commented 11 years ago

I've actually got a branch that is refactoring the positioning so what I'll do is merge in my new branch and then we can refactor your changes to fit the new code. Much appreciated.

krainboltgreene commented 11 years ago

Actually this might work fine.

krainboltgreene commented 11 years ago

Also, thanks for using it.

mileszs commented 11 years ago

I am glad my "fixes" were somewhat/temporarily useful. :-)

On Thu, Nov 15, 2012 at 3:13 AM, Kurtis Rainbolt-Greene < notifications@github.com> wrote:

Also, thanks for using it.

— Reply to this email directly or view it on GitHubhttps://github.com/krainboltgreene/termnote/pull/5#issuecomment-10400413.

krainboltgreene commented 11 years ago

Thanks for the contribute, added to gem authors list and readme.

mileszs commented 11 years ago

Thanks! You don't have to do that -- I think you rewrote everything I did, and made it much better -- but I do appreciate it!

On Sat, Nov 17, 2012 at 1:03 PM, Kurtis Rainbolt-Greene < notifications@github.com> wrote:

Thanks for the contribute, added to gem authors list and readme.

— Reply to this email directly or view it on GitHubhttps://github.com/krainboltgreene/termnote/pull/5#issuecomment-10476856.

krainboltgreene commented 11 years ago

If I create a directory for talks in the repository, can you PR it in? I would love to have it available.

mileszs commented 11 years ago

Kurtis -

Sure! I'm afraid it's not super-interesting; it was along the lines of "this is what we're doing tonight at this hack-night-style meetup." Still, I am happy to upload it. It does demonstrate chapter slides, text slides, and code slides.

MilesZS

On Mon, Nov 19, 2012 at 6:17 AM, Kurtis Rainbolt-Greene < notifications@github.com> wrote:

If I create a directory for talks in the repository, can you PR it in? I would love to have it available.

— Reply to this email directly or view it on GitHubhttps://github.com/krainboltgreene/termnote/pull/5#issuecomment-10510085.

krainboltgreene commented 11 years ago

Great, I'll push the directory tonight and you can PR your slide, or just paste it here.

mileszs commented 11 years ago

I didn't see a directory, so here's the show: https://gist.github.com/4131402

On Tue, Nov 20, 2012 at 11:46 AM, Kurtis Rainbolt-Greene < notifications@github.com> wrote:

Great, I'll push the directory tonight and you can PR your slide, or just paste it here.

— Reply to this email directly or view it on GitHubhttps://github.com/krainboltgreene/termnote/pull/5#issuecomment-10562129.