gem breaks when difference is zero

krainboltgreene / time-lord

time-lord is a ruby gem that adds extra functionality to the time class.

MIT License

156 stars 19 forks source link

gem breaks when difference is zero #2

Closed wolfwood closed 13 years ago

wolfwood commented 13 years ago

Time.now.time_ago_in_words will crash. fixed this, and various other things mentioned in commit message. please rebuild gem, this is currently breaking our site.

thanks!

james

krainboltgreene commented 13 years ago

Should've written more comprehensive tests, thanks for this. Considering you use it, which would you rather:

0 => "just now" 0 => "0 seconds ago" (What I'm doing in this pull.)

wolfwood commented 13 years ago

I think I prefer 'just now' as it is more immediately sensible, though I understand if you would rather '0 seconds ago' for consistency.

krainboltgreene commented 13 years ago

Decided to go with "just now". Made sense in retrospect.