kraiz / hamster-bridge

let your hamster log your work to your favorite bugtracker
Other
14 stars 8 forks source link

Minor enhancement for the jira worklog part #27

Closed lechndo closed 7 years ago

lechndo commented 7 years ago

Hi,

recently our company started using jira for project management. I'm using the hamster-timetracker for several years now and I do not want to stop using it or log my work twice. So I was really happy to find your little helper.

One of the minor feature lacks I have found so far was the task starting time which was not set and therefore jira used the timestamp when the worklog entry was added.

I had a look in the source, played around a little bit and found a solution which fixed the issue for me.

If I find some spare time I will also think about ways to overcome the need of polling the hamster facts and the limitation to facts that have been stopped recently. Maybe this could also bring a solution for the problem of syncing changed facts to the jira worklog.

Please have a look on my changes and and tell me what you think about my ideas.

Kind regards, lechndo

kraiz commented 7 years ago

Hey, looks pretty reasonable. Do you know, if this started param has been added lately? Do we break any old lib or server versions? I have no problems with abandoning old versions but we should document it at least :)

Implementing the first version some years ago i tried the use the dbus event trigger but it just wasn't reliable. That's the reason for the polling. But there was some kind of revival over there at the projecthamster lately. Maybe in the meantime there are better ways to bridge this gap.

elbenfreund commented 7 years ago

Hi Lars, Eric from projecthamster here. Whilst you are absolutely right that there has been significant change to the project and codebase recently we are not ready to promote a new (dbus) API yet. There will be a new dbus service soon that should provide you with a more reliable way to get the information you need, but until then I suggest you develop against 'legacy hamster' for now if you feel thats still a viable platform.

btw: seeing that you are from Dresden, do you happen to attend CLT next weekend?

lechndo commented 7 years ago

I had a look on the Jira REST API and it seems that the POST for a new worklog entry is possible since version 5.0 of the API. Have a look at the docu: https://developer.atlassian.com/static/rest/jira/5.0.html#id200804 The parameter in the jira client function was added in commit "1131f096" on 15.07.2014.

kraiz commented 7 years ago

Hey Eric, thanks for clarifying. Good old hamster is viable as it's just onboard and works okayish since years. But it's nice to see there's somebody still eager to improve it. Even better to see it's a neighbor. A pitty i missed CLT for now but I should put it on my next year's roadmap :)

@lechndo thanks for digging. I'll merge soon.