kraj / meta-clang

Clang C/C++ cross compiler and runtime for OpenEmbedded/Yocto Project
MIT License
153 stars 198 forks source link

clang.bbclass: fix recipe_sysroot_check_ld_is_lld #841

Closed jaskij closed 1 year ago

jaskij commented 1 year ago

Currently, the check added in #802 breaks my builds. I have been able to find, and fix, two cases:


Contributor checklist

Reviewer Guidelines

jaskij commented 1 year ago

While those two changes fix most of my build errors after pulling in latest Kirkstone across the board, there is one more package I have failing (depmodwrapper-cross) which also complains about the ln call in this task, so I'm marking this as a draft.

jaskij commented 1 year ago

cc @liuming50 , as the author of the original patch

jaskij commented 1 year ago

Ah, depmodwrapper-cross is a special case, it's a script, but probably not truly suited to being marked allarch. Still, I did that as a workaround.

Hmm... perhaps just test if the file exists?

[ -f "${STAGING_BINDIR_NATIVE}/${TARGET_SYS}/${TARGET_PREFIX}ld.lld" ]

Anyway, removing draft designation.

jaskij commented 1 year ago

Closing in favor of #844