"runtime:regression" in ptest gets the following FAILED: | nm: ./testprogs/uprobe_test: no symbols
Keep the debug info of uprobe_test to pass this ptest item.
'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)
"runtime:regression" in ptest gets the following FAILED: | nm: ./testprogs/uprobe_test: no symbols Keep the debug info of uprobe_test to pass this ptest item.
the steps to repruduce: $export BPFTRACE_RUNTIME_TEST_EXECUTABLE=/usr/bin $cd /usr/lib/bpftrace/ptest/tests $python3 runtime/engine/main.py --filter="regression.*" *** | [ FAILED ] regression.address_probe_invalid_expansion | Command: /usr/bin/bpftrace -e "uprobe:./testprogs/uprobe_test:0x$ | (nm ./testprogs/uprobe_test | awk '$3 == "function1" | {print $1}') { @[probe] = count(); exit() }" | Unclean exit code: 1 | Output: nm: ./testprogs/uprobe_test: no symbols\nNo probes to attach\n
Contributor checklist
Signed-off-by
is presentReviewer Guidelines