'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)
There is a gir generation error when compiled with clang
| /mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux-musl/gtk4/4.12.5/recipe-sysroot/usr/include/glib-2.0/gobject/gobject.h:822: syntax error, unexpected INTEGER, expecting identifier in ' do { if (builtin_expect (extension ({ int G_PASTE (_g_booleanvar, 9); if ((weak_pointer) == ((void)0)) G_PASTE (_g_booleanvar, 9) = 1; else G_PASTE (_g_booleanvar, 9) = 0; GPASTE ( g_booleanvar, 9); }), 1)) ; else g_assertion_message (((gchar) 0), "/mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux-musl/gtk4/4.12.5/recipe-sysroot/usr/include/glib-2.0/gobject/gobject.h ", 822, ((const char*) (func)), "'" "weak_pointer" "' should be NULL"); } while (0);' at '9' | /mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux-musl/gtk4/4.12.5/recipe-sysroot/usr/include/glib-2.0/gobject/gobject.h:822: syntax error, unexpected ')', expecting identifier or '(' in ' do { if (__builtin_expect (extension__ ({ int G_PASTE (_g_booleanvar, 9); if ((weak_pointer) == ((void)0)) G_PASTE (_g_booleanvar, 9) = 1; else G_PASTE (_g_booleanvar, 9) = 0; G_PASTE (_g_booleanvar, 9); }), 1)) ; else g_assertion_message (((gchar) 0), "/mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux-musl/gtk4/4.12.5/recipe-sysroot/usr/include/glib-2.0/gobject/gobjec t.h", 822, ((const char*) (func)), "'" "weak_pointer" "' should be NULL"); } while (0);' at ')' | Error relocating /mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux-musl/gtk4/4.12.5/build/gtk/libgtk-4.so.1: unsupported relocation type 37 | Error relocating /mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux-musl/gtk4/4.12.5/build/gtk/libgtk-4.so.1: unsupported relocation type 37 | Error relocating /mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux-musl/gtk4/4.12.5/build/gtk/libgtk-4.so.1: unsupported relocation type 37 | If the above error message is about missing .so libraries, then setting up GIR_EXTRA_LIBS_PATH in the recipe should help. | (typically like this: GIR_EXTRA_LIBS_PATH="${B}/something/.libs" )
Contributor checklist
Signed-off-by
is presentReviewer Guidelines