'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)
Somehow linker/lld here fails to link ptests with cargo, therefore workaround it by disabling lld when ptest feature is on.
Fixes errors like note: riscv64-yoe-linux-ld.lld: error: undefined symbol: PyExc_ValueError\nreferenced by bcrypt_rust.a93ef5fbf090e743-cgu.0
Contributor checklist
Signed-off-by
is presentReviewer Guidelines