Native builds of compiler-rt-sanitizers fail because llvm-ranlib, llvm-ar, and llvm-nm are not found where the recipe specifies that they'll be. Other recipes (in particular: compiler-rt) only specify the locations of those tools for target and nativesdk builds, and they build fine. This commit implements the same thing for compiler-rt-sanitizers, fixing native builds.
Note that there seems to be a separate issue with compiler-rt-sanitizers failing to build with -DCOMPILER_RT_USE_BUILTINS_LIBRARY=ON as is specified in the recipe. But with that set to OFF, the package fails to build as described above without this patch, and successfully builds with it applied.
'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)
Native builds of compiler-rt-sanitizers fail because llvm-ranlib, llvm-ar, and llvm-nm are not found where the recipe specifies that they'll be. Other recipes (in particular: compiler-rt) only specify the locations of those tools for target and nativesdk builds, and they build fine. This commit implements the same thing for compiler-rt-sanitizers, fixing native builds.
Note that there seems to be a separate issue with
compiler-rt-sanitizers
failing to build with-DCOMPILER_RT_USE_BUILTINS_LIBRARY=ON
as is specified in the recipe. But with that set toOFF
, the package fails to build as described above without this patch, and successfully builds with it applied.Contributor checklist
Signed-off-by
is presentReviewer Guidelines