krakenfx / wallet

Kraken Wallet is a powerful self-custody wallet built for the decentralized web
https://kraken.com/wallet
MIT License
138 stars 28 forks source link

Missing files for external contributors #13

Open pedrosimao opened 1 month ago

pedrosimao commented 1 month ago

Hello Krakenites,

I was interested in contributing to your open-source project and decided to try to deploy it locally. Unhappily there seems to be some missing files. Some that I already found:

After commenting those lines I still struggle with the following error:

error: node_modules/react-native-reanimated/src/reanimated2/core.ts: .../kraken-wallet/node_modules/react-native-reanimated/src/reanimated2/core.ts: Cannot find module '@babel/plugin-proposal-optional-chaining'

I have tried with and without Expo Go, just to get the same result. So, I guess I am out of luck. I would be happy to assist you in making it easy for contributors to get onboarded on this project.

Cheers, Pedro

pedrosimao commented 1 month ago

Are you using a specific version of node / yarn / expo?

Hexcrypt commented 1 month ago

Hi @pedrosimao, thank you for your interest in the project, and in contributing! The team is actively working internally to get the necessary files published to the GitHub repo that are required to build it here. Expect that in the near future we will have further updates on this, with instructions on building and contributing.

Hexcrypt commented 1 month ago

I'll leave this issue open and will update when the necessary support is added.

dukejones commented 1 month ago

Watching this - would love to get this building & maybe help improve it!

NicolasMassart commented 1 month ago

After commenting those lines I still struggle with the following error:

error: node_modules/react-native-reanimated/src/reanimated2/core.ts: .../kraken-wallet/node_modules/react-native-reanimated/src/reanimated2/core.ts: Cannot find module '@babel/plugin-proposal-optional-chaining'

@pedrosimao I added the required dependencies:

yarn add @babel/plugin-proposal-optional-chaining  @babel/plugin-proposal-nullish-coalescing-operator

Then run yarn install and yarn android.

But then when I try create the wallet, of course it crashes. Not always at the same moment, but it eventually crashes. So I believe that if Kraken team provides a proper repo with up to date debug files (I understand we don't have the keystores for release of course, but just provide the debug one which is not a secret) and then we only have to generate our own Firebase config file, then it will be a really simple and fast contributor experience.

pedrosimao commented 1 month ago

@NicolasMassart nice! Thanks for the tip. I will try on my side! I faced some similar problems when trying to contribute to metamask-mobile repo some time ago. It's open source but there is no guide on how to get started with the project. To have the project running properly we would need external dependencies not available in the git repo itself. I am not sure it is still the case. I guess making this kind of projects really open source is not that easy.

Hexcrypt commented 4 days ago

We have added some documentation on how to build and run the project locally, check out the readme for details. :tada: We will be continuing to improve external contributor experience more as time goes on.