Not allowing process.env.env to override the env:env value

krakenjs / confit

Environment-aware configuration.

Other

61 stars 26 forks source link

Not allowing process.env.env to override the env:env value #57

Closed subeeshcbabu-zz closed 8 years ago

subeeshcbabu-zz commented 8 years ago

https://github.com/krakenjs/confit/issues/56
env:env is set based on the NODE_ENV, so do not allow environment property named env to override the value.

grawk commented 8 years ago

Do you think it would be worthwhile to add a unit test for this?

subeeshcbabu-zz commented 8 years ago

Yes, totally. Unit test, on the way.

subeeshcbabu-zz commented 8 years ago

@grawk - added unit tests

grawk commented 8 years ago

👍

aliismael commented 8 years ago

We have a critical need for this request to be accepted. Can you please verify it and accept it at your earliest convenience?

shaunwarman commented 8 years ago

👍

aliismael commented 8 years ago

A million thanks, Shaun.

Yours truly, Ali

Yours truly,

Ali Ismael, Ph.D. Gaaiat, Inc

On Mon, Jul 18, 2016 at 9:13 AM, Shaun Warman notifications@github.com wrote:

Merged #57 https://github.com/krakenjs/confit/pull/57.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/krakenjs/confit/pull/57#event-726326030, or mute the thread https://github.com/notifications/unsubscribe-auth/ABCC31-Omy7408mMVCZaF9RSeKKL0EThks5qW6ZAgaJpZM4JMBEL .