Fixed issue where merging objects constructed from custom class was causing unexpected result

krakenjs / confit

Environment-aware configuration.

Other

61 stars 26 forks source link

Fixed issue where merging objects constructed from custom class was causing unexpected result #74

Closed sumeetkakkar closed 4 years ago

sumeetkakkar commented 4 years ago

Don't merge objects created from custom Classes. The merge can fail or return unexpected results depending on the Class implementation.

Below are additional changes done under this PR:

Fixed case where both initial promise and resolveImport promise in Factory._add were rejected and this caused UnhandledPromiseRejectionWarning causing unit test to fail.
Updated dependencies
Removed babel dependency for compiling

kumarrishav commented 4 years ago

PR name is incomplete I think. as it does more than that (that prototype check ) . Something like Remove babel dependency, Merge only enumerable objects (if that's what it's doing? )

Remove babel dependency. => means no need for compiling. So, I think no need to mention explicitly