search

krakenjs / cross-domain-utils

Cross Domain utilities
Apache License 2.0
131 stars 18 forks source link

Create TypeScript typings #11

Closed mstuart closed 3 years ago

mstuart commented 4 years ago

This project isn't written in TypeScript, but many TypeScript users would like to use published typings. For this issue, create TypeScript typings that cover the exported functions, and contribute it back to DefinitelyTyped!

This issue is great for someone who wants to learn more about TypeScript!

ShoeBoom commented 4 years ago

I would like to work on this

ANovokmet commented 4 years ago

I've made ANovokmet/DefinitelyTyped#cross-domain-utils-types. Should function argument types use the CrossDomainWindowType interface or Window (from lib.dom.d.ts)? Not sure about this.

ShoeBoom commented 4 years ago

Looks like @ANovokmet has already started. I'm going to leave it be this time, but you should say you want to work on something before you start.

This way you don't make other people waste their time.

ANovokmet commented 4 years ago

@ShoeBoom sorry, will do! This is my first time contributing to github open source, so I'm only aware of the guides on the Hacktoberfest page, and there is much. I might have glanced over the part where you have to claim the issue, which does make sense.

ANovokmet commented 4 years ago

Types were merged with DefinitelyTyped/DefinitelyTyped#48470.

https://www.npmjs.com/package/@types/cross-domain-utils

mstuart commented 3 years ago

Thanks!