search

krakenjs / kraken-devtools

Development-time tools for kraken.js applications.
Other
40 stars 32 forks source link

Fixing malloc and compile errors with node-sass #37

Closed jasisk closed 9 years ago

jasisk commented 9 years ago

Fixes #33. Fixes #35.

Issue was due to something over the bridge changing and, where buffers previously worked, data passed to node-sass must be a string.

jasisk commented 9 years ago

Build succeeding on 0.10. Failing on 0.11 due to (surprise!) the node-sass post-install script.

pvenkatakrishnan commented 9 years ago

why you closed this ? It seems a good step towards fixing (it works atleast with 0.10)

jasisk commented 9 years ago

just noticed something not captured by our tests. Will reopen when it's fixed / tested.

pvenkatakrishnan commented 9 years ago

ok cool :+1:

pvenkatakrishnan commented 9 years ago

This helps with running tests against node 0.10. I am a :+1: on this.

grawk commented 9 years ago

LGTM. Improves the situation.. :+1:

ygrenzinger commented 9 years ago

Great job :+1: It works even with node-sass 1.2.3

I'm impatient to have the new release (even if I can clone the master) ;)

pvenkatakrishnan commented 9 years ago

I will create one today. was hoping to get in another PR. But this does not have to wait. Will cut a release after checking all the commmits by EOD

pvenkatakrishnan commented 9 years ago

1.1.0 published

ygrenzinger commented 9 years ago

Thanks a lot! It works :)