krakenjs / kraken-devtools

Development-time tools for kraken.js applications.
Other
40 stars 32 forks source link

support custom less options #39

Closed jfgodoy closed 9 years ago

jfgodoy commented 9 years ago

this pull request add support for custom less options, for example:

"css": {
    "module": "kraken-devtools/plugins/less",
    "files": "/css/**/*.css",
    "relativeUrls": true
}

Is the api ok? or prefer this way:

"css": {
    "module": "kraken-devtools/plugins/less",
    "files": "/css/**/*.css",
    "options": {
        "relativeUrls": true
    }
}
jasisk commented 9 years ago

Just adding a quick note here: build failure on 0.11 due to node-sass. Disregard.

aredridel commented 9 years ago

https://github.com/krakenjs/kraken-devtools/pull/52 should fix the node-sass failure

grawk commented 9 years ago

@jfgodoy would you have time to re-open this PR against the new separate plugin: construx-less ? We are going to recommend people migrate to the new, more atomic construx family of modules and discourage further code changes to this module.