search

krakenjs / kraken-devtools

Development-time tools for kraken.js applications.
Other
40 stars 32 forks source link

fix issue where errors were not being caught #40

Closed xjamundx closed 9 years ago

xjamundx commented 9 years ago

The try/catch here was not working as expected. I found the following change would correctly handle the errors.

Caveat, I'm not a streams pro AT ALL. I straight up stole this from here: http://stackoverflow.com/questions/21771220/error-handling-with-node-js-streams

Let me know if you have any other thoughts or ideas!

xjamundx commented 9 years ago

Added a test to ensure that it works (and verified the test failed before)

pvenkatakrishnan commented 9 years ago

Also jamund, did you pull in the latest from master ? I dont see some changes in master on this file on the changed one ?

pvenkatakrishnan commented 9 years ago

for example fix to check if templates exist in this commit ..https://github.com/krakenjs/kraken-devtools/commit/994717c480b7a2246dfdf97838b3de0d9eb08b84

pvenkatakrishnan commented 9 years ago

ups sorry closed by mistake.

xjamundx commented 9 years ago

let me rebase, then the tests might stop failing :)

xjamundx commented 9 years ago

Unclear why the thing is failing, tests pass locally

pvenkatakrishnan commented 9 years ago

@xjamundx the tests are failing on travis due to an unrelated issue in the sass compiler which is incompatible between 0.10 and 0.11 of node. Travis runs all our jobs against both versions and hence failing. There is an issue open in node-sass which with next version should fix to work seamlessly. Don't worry about that.

pvenkatakrishnan commented 9 years ago

if you;d like more info on that issue https://github.com/krakenjs/kraken-devtools/issues/35

pvenkatakrishnan commented 9 years ago

Merging this in.

xjamundx commented 9 years ago

thanks!