search

krakenjs / kraken-devtools

Development-time tools for kraken.js applications.
Other
40 stars 32 forks source link

Factorize next() and return #55

Closed kylekatarnls closed 9 years ago

kylekatarnls commented 9 years ago

Avoid using early-return and this is same result and same work factor.

jasisk commented 9 years ago

Hi @kylekatarnls,

We often choose a style based on legibility and not terseness. We find that it helps encourage contribution and—personally—I find it more helpful when having to manually parse lots and lots of code day in and day out.

Additionally, we're generally not inclined to make stylistic changes for the sake of style. We can certainly considering this sort of stuff with other functional refactors, but I'm inclined to :-1: this. Anyone else want to comment?

In any case, I appreciate you taking the time to submit the PR.

aredridel commented 9 years ago

Agreed -- I prefer the earlier style better.

grawk commented 9 years ago

Just as an FYI @kylekatarnls, we are planning the future of kraken-devtools. If you'd like to voice your opinion there we'd really appreciate it. Please view the issues marked as v2.x