search

krakenjs / kraken-example-with-passport

An example integrating kraken with passport authentication
53 stars 33 forks source link

requirejs? #18

Open dennishall1 opened 8 years ago

dennishall1 commented 8 years ago

I noticed requirejs is a dependency, but I don't see where it is used. Perhaps there was a thought of using it, but it didn't materialize? (npm uninstall requirejs .. site runs fine without it, so do builds.)

aredridel commented 8 years ago

Nice catch. requirejs was used in older versions, but perhaps incompletely removed. Tidying up patches are welcome!

grawk commented 8 years ago

Agree with you both. @dennishall1 if you have time to PR the removal of requirejs that'd be awesome. I'm moving through the various examples and ticking off higher priority items. Eventually I'd get to this one but would be happy to have the help if you're able.