search

krakenjs / kraken-example-with-passport

An example integrating kraken with passport authentication
53 stars 33 forks source link

app.less unused styles #19

Open dennishall1 opened 8 years ago

dennishall1 commented 8 years ago

I can see this either way ... app.less has unused styles, but I can see that it might be convenient to keep app.less more or less the same across kraken-example-* projects.

For example, the following style rule caught my attention, since it is usually frowned upon to write style rules that have a trailing universal selector: .lang * { ... }

grawk commented 8 years ago

Oh yeah * has bitten me before. I never use it after I had a run-in with it many years ago. It's existence here is a result of a copy-paste and failure to remove extraneous styles. As with the other issue(s) you've raised, if you file a PR to resolve it, it would be greatly appreciated. Otherwise, anyone else would be welcome to do so as well.