search

krakenjs / kraken-example-with-passport

An example integrating kraken with passport authentication
53 stars 33 forks source link

Change bcrypt version for windows support #5

Closed josh-birk closed 9 years ago

aredridel commented 9 years ago

LGTM!

josh-birk commented 9 years ago

Hi Aria,

Thanks for merging that so quickly. I have a quick question/concern. This example code is actually included in two places: 1.https://github.com/krakenjs/kraken-example-with-passport 2.https://github.com/krakenjs/kraken-examples/tree/master/with.passport

So any changes should be made to both... Why was this setup like this? I can make another pull request for the other repository if you want, but I also want to make some changes to the readme to clear up some of that confusion and also mention the need for visual studio for windows. I can do a separate pull request for that.

Let me know what you would prefer.

Thanks, Josh

On Thu, Mar 19, 2015 at 10:11 PM, Aria Stewart notifications@github.com wrote:

Merged #5 https://github.com/krakenjs/kraken-example-with-passport/pull/5.

— Reply to this email directly or view it on GitHub https://github.com/krakenjs/kraken-example-with-passport/pull/5#event-260155860 .

aredridel commented 9 years ago

I need to kill off the merged repo and update some doc links. This is the canonical one now!