search

krakenjs / lusca

Application security for express apps.
Other
1.79k stars 139 forks source link

Extra value types for xframe #144

Closed linkRace closed 3 years ago

linkRace commented 3 years ago

Adds options to have xframe header set on blocklist/allowlist format or by custom defined functions.

Tests added for all cases.

linkRace commented 3 years ago

@grawk looking to publish a 1.7.0 with this and #143 , let me know what you think.

linkRace commented 3 years ago

Believe I've addressed all the comments outside of the trailing / issue. I could add in logic checking for a route name and/or a trailing /. Wouldn't want to break any existing functionality with a minor version bump, but I'm not sure that's the intended behavior. Let me know your thoughts.

maxmil7 commented 3 years ago

Change partially implemented in #145 Closing this PR for the time being.