search

krakenjs / lusca

Application security for express apps.
Other
1.79k stars 122 forks source link

Handle boolean values properly in xss protection #20

Closed runk closed 10 years ago

jeffharrell commented 10 years ago

Nice catch. One minor request, rather than coercing the value with each request, can you move the + to https://github.com/runk/lusca/blob/9e769c107736b6612e7676be41b875e410535c3b/lib/xssprotection.js#L10 ?

runk commented 10 years ago

Oh. That's a shame that I didn't spot that place. Fixed :+1:

jeffharrell commented 10 years ago

Awesome. Thanks for the test case too!