Support koa style middleware

krakenjs / lusca

Application security for express apps.

Other

1.79k stars 122 forks source link

Support koa style middleware #26

Closed fengmk2 closed 10 years ago

fengmk2 commented 10 years ago

koa is become more and more popular, it's time to support the new style middlewares.

Use old test codes to test koa changes
Keep koa usage just like express, only one more options.koa = true

Because node 0.10.x don't support --harmony, current unit test only pass on node 0.11.x.

$ npm run test-express: only test express $ npm run test-koa: only test koa $ npm test: test express and koa both

ForbesLindesay commented 10 years ago

express is still about 100 times more popular by npm downloads (at least on week days). Supporting koa adds a lot of complexity to this module. Would it not make more sense to just add koa-lusca?

haoxins commented 10 years ago

+1 for koa-lusca.

And is it better to split a module lusca-core?

fengmk2 commented 10 years ago

It's easy to make a koa-lusca, but I want to reuse the same codes and logic.