search

krakenjs / lusca

Application security for express apps.
Other
1.79k stars 123 forks source link

Updated HSTS to support the preload flag #51

Closed amotmot closed 9 years ago

amotmot commented 9 years ago

Hey, I've updated the HSTS implementation to support the preload flag. This flag is required for HSTS domain submissions to Chrome's preload list. The changes include new feature support, new test case, and updated docs. More information regarding preload is available below

https://hstspreload.appspot.com/

aredridel commented 9 years ago

Wow, great PR. :+1:

pvenkatakrishnan commented 9 years ago

thanks for the pr! there seems to be a lint error. can you check running grunt test ?

amotmot commented 9 years ago

@pvenkatakrishnan, I've fixed the lint error.

pvenkatakrishnan commented 9 years ago

thanks merging.

amotmot commented 9 years ago

@pvenkatakrishnan or @aredridel how long before this change makes its way to npm i lusca? I'm not seeing the preload logic after a npm install.

aredridel commented 9 years ago

The lead maintainer is at a conference, but I bet we can track him down in the next few days!

jasisk commented 9 years ago

Hi @gellerb,

I was tracked down. :) Published as v1.1.0.

amotmot commented 9 years ago

@jasisk Thanks.