search

krakenjs / post-robot

Cross domain post-messaging on the client side using a simple listener/client pattern.
Apache License 2.0
746 stars 91 forks source link

Fix for ignoring timeout #46

Closed mrVictorios closed 6 years ago

mrVictorios commented 6 years ago

Hello,

in a use case wich requires to set the timeout, post-robot still ignore the value. This fix the issue. Reason for the issue the "timeout" option was not passed to the send method.

*fix style

bluepnume commented 6 years ago

Can you please:

mrVictorios commented 6 years ago

I made the adjustments.

bluepnume commented 6 years ago
  • Please only make changes to src/ and remove any refactoring, style changes, or changes to /dist. Once your change is merged I'll build and publish.

^ I'm still seeing this, along with a lot of console logs. Can you please just add the two lines that are necessary for this change in src/ -- the change to config.js, and the change to ready.js to set the default window load timeout.

mrVictorios commented 6 years ago

I created a new branch from my master and reset it to the commit f7daefd and add my changes.

bluepnume commented 6 years ago

Doesn't seem to have worked -- https://github.com/krakenjs/post-robot/pull/46/files still shows a lot of changes that aren't needed for this PR. Did you push your changes to your fork?

mrVictorios commented 6 years ago

Ok I close this Pull Request Create a new Fork with changes, that should be passed :)