krakenjs / spud

A content store parser, reading a java .properties-like format
Other
14 stars 9 forks source link

Add fallbacks #8

Closed aredridel closed 10 years ago

tlivings commented 10 years ago

:+1: :hammer:

pvenkatakrishnan commented 10 years ago

:+1: merging.

totherik commented 10 years ago

Prior to publishing, a few things:

pvenkatakrishnan commented 10 years ago

yes i am in the process of doing the travis part... by mistake i checked in directly instead of a PR.. apologies... will finish it up now.

totherik commented 10 years ago

So, this MUST be a major version change. It's possible there are existing properties files that use the key include as a content key, rendering this a not-backward-compatible update.

aredridel commented 10 years ago

Oh bother, that's true. We can search ours, but not the world's.

pvenkatakrishnan commented 10 years ago

hmmm yeah I missed that one possibility. possibly call out on the documentation as a 'reserved' key

aredridel commented 10 years ago

Definitely must!

aredridel commented 10 years ago

It is called out in the README (Not highlighted, but mentioned)