krakenjs / swaggerize-express

Design-driven apis with swagger 2.0 and express.
Other
354 stars 81 forks source link

v5.x #121

Closed subeeshcbabu-zz closed 6 years ago

subeeshcbabu-zz commented 7 years ago
gabrielcsapo commented 7 years ago

LGTM @subeeshcbabu 👍

gonenduk commented 7 years ago

Can't wait for this release. The previous validations were not good (I even had to fix some myself. Made a pull request - but now I understand why it is not longer relevant). Please release it as soon as you can. Thanks!

gonenduk commented 7 years ago

Any update on release date?

gabrielcsapo commented 7 years ago

👍

shaunwarman commented 7 years ago

👍 🍾

gonenduk commented 7 years ago

any updates on release date?

tlivings commented 6 years ago

@subeeshcbabu @shaunwarman you guys want to complete merging this into master and publish it?

gonenduk commented 6 years ago

Would be great if you publish the new version to npm

gabrielcsapo commented 6 years ago

@subeeshcbabu is working on that this weekend 😄

gonenduk commented 6 years ago

any updates?

subeeshcbabu-zz commented 6 years ago

Published an alpha version swaggerize-express@5.0.0-alpha.1.

Will publish the rc and 5.0.0 soon. Would be awesome if anyone could try this alpha and provide feedback.

gonenduk commented 6 years ago

I have an issue with the alpha. Where do I provide feedback? Create a new issue?

subeeshcbabu-zz commented 6 years ago

Thanks for trying out the alpha. Yeah, please create an issue with all the details.

gonenduk commented 6 years ago

OK, everything is working SUPER well (for me) with the new version. Any estimates for the release date (with the bug fix)?

subeeshcbabu-zz commented 6 years ago

@gonenduk Thanks for testing this out. I will have to publish a version of the routes module first and then this one.

I don't see an issue with publishing modules because this is a major version. You can expect something by end of this week.

gonenduk commented 6 years ago

Can you also check the PR I did in the routes package (for version 2.x)? defaulthandler in options

It's not the same defaulthandler of version 1.x which was quite useless. It's actually a fallback handler in case other handlers are not defined. It's useful to use this to report "501 not implemented" or to create another behavior which is common to all.