Closed subeeshcbabu-zz closed 6 years ago
LGTM @subeeshcbabu 👍
Can't wait for this release. The previous validations were not good (I even had to fix some myself. Made a pull request - but now I understand why it is not longer relevant). Please release it as soon as you can. Thanks!
Any update on release date?
👍
👍 🍾
any updates on release date?
@subeeshcbabu @shaunwarman you guys want to complete merging this into master and publish it?
Would be great if you publish the new version to npm
@subeeshcbabu is working on that this weekend 😄
any updates?
Published an alpha version swaggerize-express@5.0.0-alpha.1
.
Will publish the rc and 5.0.0
soon. Would be awesome if anyone could try this alpha and provide feedback.
I have an issue with the alpha. Where do I provide feedback? Create a new issue?
Thanks for trying out the alpha. Yeah, please create an issue with all the details.
OK, everything is working SUPER well (for me) with the new version. Any estimates for the release date (with the bug fix)?
@gonenduk Thanks for testing this out. I will have to publish a version of the routes
module first and then this one.
I don't see an issue with publishing modules because this is a major version. You can expect something by end of this week.
Can you also check the PR I did in the routes package (for version 2.x)? defaulthandler in options
It's not the same defaulthandler of version 1.x which was quite useless. It's actually a fallback handler in case other handlers are not defined. It's useful to use this to report "501 not implemented" or to create another behavior which is common to all.
Use
swaggerize-routes^2
joischema
totrue
to use Joi schema validator. Uses enjoi - The json to joi schema converter - to build the validator functions.Start the server (or
listen
to port) only onroute
event emitted by the app. Route builder is an async api, now capable of parsing and validating remote $ref in swagger spec, so the app/server need to wait for theroute
event before processing requests.es6 changes