krakenjs / swaggerize-express

Design-driven apis with swagger 2.0 and express.
Other
355 stars 81 forks source link

Routes : Added HTTP 405 handler middleware #78

Closed nbcraft closed 8 years ago

nbcraft commented 9 years ago

I added a 405 handler middleware to respect REST patterns : http://www.restpatterns.org/HTTP_Status_Codes/405_-_Method_Not_Allowed

nbcraft commented 9 years ago

Hey :) Did you have time to take a look at this ? The Travis check seems to have failed while installing node 0.10 I don't feel like pushing a new commit just to trigger the checks again. Thanks in advance ;) Nathan

aredridel commented 8 years ago

I re-ran CI and it passed-- error in travis infrastructure.

tlivings commented 8 years ago

Other than the code style comments, I need to think about this approach a little more.

nbcraft commented 8 years ago

Penny for your thoughts? :wink:

tlivings commented 8 years ago

Yeah, I think this looks good to me. Also cc @subeeshcbabu.