search

krakenjs / swaggerize-express

Design-driven apis with swagger 2.0 and express.
Other
355 stars 81 forks source link

bugfix(routes): Handle file upload in formData #89

Closed kenjones-cisco closed 7 years ago

kenjones-cisco commented 8 years ago

The vauleAccessor for formData assumed that the attribute would always be in the body but all of the multipart parsers for file uploads result in the vaules being stored in req.file attribute.

Test form data will fail currently until krakenjs/swaggerize-routes#55 has been merged in as well.

Related to: krakenjs/swaggerize-routes#54

kenjones-cisco commented 8 years ago

82 & #88

tlivings commented 8 years ago

Sorry this has not seen action. Can you address CI and we can merge?

kenjones-cisco commented 8 years ago

Sure, will look at that today.

kenjones-cisco commented 8 years ago

The test fails because a new version of swaggerize-routes has not been released. The PR (https://github.com/krakenjs/swaggerize-routes/pull/55) that was merged there is the other half of this change. To fix the issue with this test case, I would have to change package.json to point to master branch of swaggerize-routes or have the test case ignored.

kenjones-cisco commented 8 years ago

@tlivings With the release of the swaggerize-routes the tests are now passing.

subeeshcbabu-zz commented 8 years ago

lgtm

kenjones-cisco commented 8 years ago

@tlivings bump