search

krakenjs / swaggerize-routes

Swagger document driven route builder.
Other
58 stars 57 forks source link

Made `true` truthy #47

Closed dncrews closed 9 years ago

dncrews commented 9 years ago

Fixes an issue where true is not truthy.

This issue arises when you're using

  - name: someBool
    in: formData
    type: boolean
    default: false

If you send the data using JSON, true is taken as the value, and then is coerced to false. Test plan updated to validate.

tlivings commented 9 years ago

:+1:

jamesblack commented 9 years ago

@tlivings

tlivings commented 9 years ago

We have a two :+1: requirement on merges :) will poke someone to get another look.

aredridel commented 9 years ago

:+1:

dncrews commented 9 years ago

@tlivings, does this mean I can get a merge? What's the likelihood of getting a release?

tlivings commented 9 years ago

Published in 1.0.5.