krakenjs / swaggerize-routes

Swagger document driven route builder.
Other
58 stars 57 forks source link

Fix route merge with multiple refs #69

Closed vietthang closed 8 years ago

vietthang commented 8 years ago

I found a bug with the library where there are multiple parameters with $ref in route. In that case, only the validator for last parameter is used. I updated the test schema and added a simple test case. Please check this pull request for details.

subeeshcbabu-zz commented 8 years ago

Thanks for the PR. However i am working on the next version of the module which uses swagger parser to dereference the api before building the validators. Is this change urgent for a patch release?

vietthang commented 8 years ago

@subeeshcbabu: It's fine. It's quite a long time ago and I did some work around. Thank you for your reply.