krakenjs / swaggerize-routes

Swagger document driven route builder.
Other
58 stars 57 forks source link

query parameter "required" not being enforced #88

Open ekreiser opened 7 years ago

ekreiser commented 7 years ago

swagger snippet { "in": "query", "name": "since", "description": "", "required": true, "type": "string" }

in 1.0.6 this was enforced to mean that a "since" value needed to be passed in the query string to the endpoint. --this would validate http://domain/api/endpoint&since=blah --this would fail validation http://domain/api/endpoint http://domain/api/endpoint&since=

in 1.0.10 this is only enforcing that a "since" argument name is present but is passing validation even when no value is passed along with the argument --this would validate http://domain/api/endpoint&since= --this would fail validation http://domain/api/endpoint