search

krakenjs / swaggerize-routes

Swagger document driven route builder.
Other
58 stars 57 forks source link

Update to enjoi 3.x depdendency #95

Closed dtzar closed 4 years ago

dtzar commented 6 years ago

This resolves the vulnerability problem listed here: https://github.com/krakenjs/swaggerize-routes/issues/94 The fix from @iamjoeker only resolves the problem with the enjoi itself while swaggerize-routes still uses the 1.x version of enjoi which has the downstream dependency problem.

ESRogs commented 6 years ago

@dtzar Do you know why this build failed?

(Would love to see this merged, to fix the security vulnerability!)

jkingoliver commented 6 years ago

enjoi is now up to 4.0.0. We'd also love to see this package updated to fix security vulnerabilities.

computnik commented 5 years ago

+1 Any updates on this? Would love to see this merged soon! @dtzar seems build is failing.

dtzar commented 5 years ago

Yes, the build failed with the latest 3.x and fails in a different way with 4.x. It needs more work / debugging - I just haven't had the time to get to it.

tlivings commented 5 years ago

I think the better path here is to get the 2.x branch merged. maintainers have been absent though.

otroyko commented 5 years ago

Any updates on this PR? Security vulnerability fix, please merge it ASAP.

dtzar commented 4 years ago

Considering no PRs have been approved/merged in a VERY long time, I'm going to assume this package is no longer supported. Therefore, I don't have the desire to troubleshoot why the tests are failing for the dependency updates. So, I'll close my PR out. If the kraken-js team or whomever has contributor rights to this repo fixes the maintainer problem https://github.com/krakenjs/swaggerize-routes/issues/89 I'll consider investing time to complete this.