search

krakenjs / zoid

Cross domain components
Apache License 2.0
2.03k stars 248 forks source link

"Cannot read property 'Ua' of undefined" in v2.0.23 #81

Closed emiloberg closed 7 years ago

emiloberg commented 7 years ago

When upgrading (yarn remove xcomponent && yarn add xcomponent) from 2.0.22 to 2.0.23, I'm getting the following error in my browser console:

Cannot read property 'Ua' of undefined

skarmavbild 2017-04-24 kl 13 17 56

When trying to figure out why this is happening I built the dist files from the repo (as of 7f83bf2) and copied into my node_modules. Interesting enough, everything is then working fine. Which leads me to believe that the dist folder on npm is not up to speed, could this be correct?

Building this way:

git clone ...
npm install
./node_modules/.bin/gulp build
cp dist/xcomponent.js xxx/node_modules/xcomponent/dist
harouny commented 7 years ago

I can produce same error in 2.0.23

sonoman commented 7 years ago

Demo Site is throwing the same error.

bluepnume commented 7 years ago

Fixed. Thanks for the heads up. I had uglify prop-mangling enabled on my localhost when I merged and built the latest PR. Gotta add something to my publish script to prevent any un-staged changes making it into /dist. Sorry all!

sonoman commented 7 years ago

fix is working. thanks for the prompt response !