search

krakenjs / zoid

Cross domain components
Apache License 2.0
2.03k stars 248 forks source link

xcomponent.frame.js undefined popUpWindow. #83

Closed mmairs9-zz closed 7 years ago

mmairs9-zz commented 7 years ago

Receiving Js Error popupWindowsByWin is undefined in latest dist version of xcomponent.frame.js in the cleanUp function __WEBPACK_IMPORTED_MODULE_0global.a.popupWindowsByWin.delete(win);

Should it have reference to popUp window?

bluepnume commented 7 years ago

Checking on this, thanks for the catch. I suspect this needs to be conditionally excluded from the frame-specific build.

bluepnume commented 7 years ago

Should be fixed, can you try the latest published version?

mmairs9-zz commented 7 years ago

Awesome this looks to have been fixed no longer seeing the error. I did notice that the default log functionality that was recently added did not seem to be take effect with xcomponent.frame.js.

I have it set as defaultLogLevel: 'error'

harouny commented 7 years ago

@mmairs9 Its logLevel:'error' please try and let me know

harouny commented 7 years ago

Sorry my bad.... defaultLogLevel when creating component and logLevel in props when rendering component.

bluepnume commented 7 years ago

That's weird -- let me take a look. The frame build should include all of the log-level related code...

mmairs9-zz commented 7 years ago

this looks good to me now!

bluepnume commented 7 years ago

Oh glad it works -- didn't actually fix anything, maybe you had an old version? Closing this issue anyway.