Fix ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX

krakjoe / ui

Cross platform UI development in PHP

Other

518 stars 39 forks source link

Fix ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX #42

Closed petk closed 5 years ago

petk commented 6 years ago

Hello, this patch fixes some copy/paste typo. The new macro ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX takes only 5 arguments otherwise compilation fails with the following error on PHP 7.2:

...ui/classes/box.c:188:91: error: macro "ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX" passed 6 arguments, but takes just 5
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(php_ui_box_is_padded_info, 0, 0, _IS_BOOL, NULL, 0)

jgmdev commented 6 years ago

LoL I opened a pull request #51 for the same stuff without taking a look at the existing pull requests.

petk commented 5 years ago

Hello, any update here?